Re: Broken ./configure checks for __cpuid() and __cpuidex()
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-29T03:01:03Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > While looking at the surroundings, I have noticed a second check > that's incorrect in ./configure.ac, with __cpuid(). I may be missing > something, of course, but these two typos have been introduced by > 3dc2d62d0486, back in 2015. meson is doing these checks correctly. I > have not been able to test that on cirrus, it seems to run into > problems this morning. I don't know much about these instructions, > but it seems like __get_cpuid_count() and __get_cpuid() are much more > populate than the two others, so the impact may be lighter than I > suspect for builds using ./configure. That's clearly broken. Some quick googling suggests that __cpuid and __cpuidex are Microsoft-isms, so this would only affect autoconf-based builds on Windows, which probably explains how we didn't notice. Still, oughta fix it. regards, tom lane
Commits
-
Fix ./configure checks with __cpuidex() and __cpuid()
- 612f5b80620d 13.22 landed
- 60953d4cba7c 14.19 landed
- d6ffc43f95b2 15.14 landed
- c1984be23cdc 16.10 landed
- 8de56323c139 17.6 landed
- cd2d52cc6b39 18.0 landed
- 1a5212775e46 19 (unreleased) landed