Horton

Re: longfin missing gssapi_ext.h

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Jonathan S. Katz" <jkatz@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-04-12T16:37:26Z
Lists: pgsql-hackers 
> On 12 Apr 2023, at 16:55, Stephen Frost <sfrost@snowman.net> wrote:
> 
> Greetings,
> 
> * Daniel Gustafsson (daniel@yesql.se) wrote:
>>> On 12 Apr 2023, at 16:33, Stephen Frost <sfrost@snowman.net> wrote:
>>> Sure, reworked that way and attached.
>> 
>> While not changed in this hunk, does the comment regarding Heimdal still apply?
>> 
>> @@ -918,6 +919,7 @@ pg_GSS_recvauth(Port *port)
>> 	int			mtype;
>> 	StringInfoData buf;
>> 	gss_buffer_desc gbuf;
>> +	gss_cred_id_t delegated_creds;
>> 
>> 	/*
>> 	 * Use the configured keytab, if there is one.  Unfortunately, Heimdal
> 
> Good catch.  No, it doesn't.  I'm not anxious to actually change that
> code at this point but we could certainly consider changing it in the
> future.  I'll update this comment (and the identical one in
> secure_open_gssapi) accordingly.

Sounds like a good plan.

--
Daniel Gustafsson

Commits

  1. Further cleanup of autoconf output files for GSSAPI changes.

  2. Update Kerberos/GSSAPI configure/meson check

  3. Explicitly require MIT Kerberos for GSSAPI

  4. De-Revert "Add support for Kerberos credential delegation"

  5. Revert "Add support for Kerberos credential delegation"