Horton

Re: report expected contrecord size

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-03T21:31:31Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> A pretty minor issue: when reporting that WAL appears invalid because
> contrecord length doesn't match, we may as well print to the server log
> the value that we're expecting.  Patch attached.

ITYW

+                                      (long long) (total_len - gotlen),

just to be sure about what's getting casted to what.  Otherwise +1.

			regards, tom lane

Commits

  1. Report expected contrecord length on mismatch