Horton
Menu

Re: [HACKERS] Streaming replication document improvements

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Josh Berkus <josh@agliodbs.com>, Kevin Grittner <Kevin.Grittner@wicourts.gov>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-docs@postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-20T23:53:36Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> Current logic says we hit the connection limit if:

>         if (!am_superuser &&
>                 ReservedBackends > 0 &&
>                 !HaveNFreeProcs(ReservedBackends))

> Couldn't we just change this to:

>         if ((!am_superuser || am_walsender) &&
>                 ReservedBackends > 0 &&
>                 !HaveNFreeProcs(ReservedBackends))

As of the patch I just committed, that code is not reached anymore by a
walsender process.  However, it shouldn't be hard to put a similar test
into the walsender code path.

			regards, tom lane