Horton

Thread

Commits

  1. Fix misleading error message context

  1. strange context message in spi.c?

    Pavel Stehule <pavel.stehule@gmail.com> — 2024-06-13T17:21:57Z

    Hi

I am found strange switch:

<--><-->switch (carg->mode)
<--><-->{
<--><--><-->case RAW_PARSE_PLPGSQL_EXPR:
<--><--><--><-->errcontext("SQL expression \"%s\"", query);
<--><--><--><-->break;
<--><--><-->case RAW_PARSE_PLPGSQL_ASSIGN1:
<--><--><-->case RAW_PARSE_PLPGSQL_ASSIGN2:
<--><--><-->case RAW_PARSE_PLPGSQL_ASSIGN3:
<--><--><--><-->errcontext("PL/pgSQL assignment \"%s\"", query);
<--><--><--><-->break;
<--><--><-->default:
<--><--><--><-->errcontext("SQL statement \"%s\"", query);
<--><--><--><-->break;
<--><-->}

Is the message "SQL expression ..." for RAW_PLPGSQL_EXPR correct?

Should there  be a "PL/pgSQL expression" instead?

Regards

Pavel

  2. Re: strange context message in spi.c?

    Daniel Gustafsson <daniel@yesql.se> — 2024-06-13T18:56:20Z

    > On 13 Jun 2024, at 19:21, Pavel Stehule <pavel.stehule@gmail.com> wrote:

> Is the message "SQL expression ..." for RAW_PLPGSQL_EXPR correct?

That indeed seems incorrect.

> Should there  be a "PL/pgSQL expression" instead?

I think that would make more sense.

--
Daniel Gustafsson

  3. Re: strange context message in spi.c?

    Pavel Stehule <pavel.stehule@gmail.com> — 2024-06-15T06:59:49Z

    Hi

čt 13. 6. 2024 v 20:56 odesílatel Daniel Gustafsson <daniel@yesql.se>
napsal:

> > On 13 Jun 2024, at 19:21, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>
> > Is the message "SQL expression ..." for RAW_PLPGSQL_EXPR correct?
>
> That indeed seems incorrect.
>
> > Should there  be a "PL/pgSQL expression" instead?
>
> I think that would make more sense.
>

here is the patch

Regards

Pavel


>
> --
> Daniel Gustafsson
>
>

  4. Re: strange context message in spi.c?

    Stepan Neretin <sncfmgg@gmail.com> — 2024-06-24T09:14:05Z

    Hi! Looks good to me!
Best regards, Stepan Neretin.

  5. Re: strange context message in spi.c?

    Daniel Gustafsson <daniel@yesql.se> — 2024-06-24T19:04:32Z

    > On 24 Jun 2024, at 11:14, Stepan Neretin <sncfmgg@gmail.com> wrote:
> 
> Hi! Looks good to me! 

Thanks for review.  I have this on my TODO for when the tree branches, it
doesn't seem like anything worth squeezing in before then.

--
Daniel Gustafsson

  6. Re: strange context message in spi.c?

    Umar Hayat <postgresql.wizard@gmail.com> — 2024-08-03T05:43:47Z

    The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            tested, failed

As tree is branched out for PG17, I guess now it's time to commit.
- No need to rebase
- make, make-check , install-check verified

The new status of this patch is: Ready for Committer

  7. Re: strange context message in spi.c?

    Peter Eisentraut <peter@eisentraut.org> — 2024-09-05T13:25:47Z

    On 03.08.24 07:43, Umar Hayat wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, failed
> Implements feature:       tested, failed
> Spec compliant:           tested, failed
> Documentation:            tested, failed
> 
> As tree is branched out for PG17, I guess now it's time to commit.
> - No need to rebase
> - make, make-check , install-check verified
> 
> The new status of this patch is: Ready for Committer

committed