Re: Misleading errors with column references in default expressions and partition bounds
Amit Langote <langote_amit_f8@lab.ntt.co.jp>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-29T02:55:48Z
Lists: pgsql-hackers
On 2019/03/28 21:14, Michael Paquier wrote: > On Wed, Mar 27, 2019 at 12:13:16PM +0900, Michael Paquier wrote: >> ParseExprKind is an enum, so listing all the options without the >> default has the advantage to generate a warning if somebody adds a >> value. This way anybody changing this code will need to think about >> it. > > A bit late, but committed without the case/default. > >>> ... The value >>> is any variable-free expression (in particular, cross-references >>> to other columns in the current table are not allowed). Subqueries >>> are not allowed either. >> >> Okay, I think I see your point here. That sounds sensible. > > And I have used this suggestion from Tom as well for the docs. Thanks Michael for taking care of this. Regards, Amit
Commits
-
Improve error handling of column references in expression transformation
- ecfed4a12247 12.0 landed