Re: Wait event that should be reported while waiting for WAL archiving to finish

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Date: 2020-02-17T07:24:12Z
Lists: pgsql-hackers

On 2020/02/14 15:45, Michael Paquier wrote:
> On Fri, Feb 14, 2020 at 12:47:19PM +0900, Fujii Masao wrote:
>> logical_rewrite_truncate_v1.patch adds the description of
>> LogicalRewriteTruncate into the doc. This needs to be
>> back-patched to v10 where commit 249cf070e3 introduced
>> LogicalRewriteTruncate event.
> 
> Indeed.  You just be careful about the number of fields for morerows,
> as that's not the same across branches.
> 
>> gss_open_server_v1.patch adds the description of GSSOpenServer
>> into the doc and update the code in pgstat_get_wait_client().
>> This needs to be applied in v12 where commit b0b39f72b9 introduced
>> GSSOpenServer event.
>>
>> gss_open_server_for_master_v1.patch does not only what the above
>> patch does but also update wait event enum into alphabetical order.
>> This needs to be applied in the master.
> 
> Thanks for splitting things.  All that looks correct to me.

Thanks for the review! Pushed the patches for
LogicalRewriteTruncate and GSSOpenServer.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters



Commits

  1. Add wait events for WAL archive and recovery pause.

  2. Add description about GSSOpenServer wait event into document.

  3. Add description about LogicalRewriteTruncate wait event into document.

  4. GSSAPI encryption support

  5. Create and use wait events for read, write, and fsync operations.