Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

Erik Rijkers <er@xs4all.nl>

From: Erik Rijkers <er@xs4all.nl>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Amit Kapila <amit.kapila16@gmail.com>, Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2020-04-22T16:01:23Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Tighten the concurrent abort check during decoding.

  2. Improve hash_create()'s API for some added robustness.

  3. Use HASH_BLOBS for xidhash.

  4. Fix initialization of RelationSyncEntry for streaming transactions.

  5. Remove unused function declaration in logicalproto.h.

  6. Add additional tests to test streaming of in-progress transactions.

  7. Fix inline marking introduced in commit 464824323e.

  8. Add support for streaming to built-in logical replication.

  9. Fix the SharedFileSetUnregister API.

  10. Fix comment in procarray.c

  11. Suppress compiler warning in non-cassert builds.

  12. Extend the BufFile interface.

  13. Mark a few logical decoding related variables with PGDLLIMPORT.

  14. Implement streaming mode in ReorderBuffer.

  15. Extend the logical decoding output plugin API with stream methods.

  16. WAL Log invalidations at command end with wal_level=logical.

  17. Immediately WAL-log subtransaction and top-level XID association.

  18. Allow logical replication to transfer data in binary format.

  19. Only superuser can set sslcert/sslkey in postgres_fdw user mappings

  20. Track statistics for spilling of changes from ReorderBuffer.

  21. Add logical_decoding_work_mem to limit ReorderBuffer memory usage.

  22. logical decoding: process ASSIGNMENT during snapshot build

  23. Emit invalidations to standby for transactions without xid.

On 2020-04-22 16:49, Dilip Kumar wrote:
> On Tue, Apr 21, 2020 at 5:30 PM Dilip Kumar <dilipbalaut@gmail.com> 
> wrote:
>> 
>> >
>> >     (by the way: this build's regression tests  'ddl', 'toast', and
>> > 'spill' fail)
>> 
>> Yeah, this is a. known issue, actually, while streaming the
>> transaction the output message is changed.  I have a plan to work on
>> this part.
> 
> I have fixed this part.  Basically, now, I have created a separate
> function to get the streaming changes
> 'pg_logical_slot_get_streaming_changes'.  So the default function
> pg_logical_slot_get_changes will work as it is and test decoding test
> cases will not fail.

The 'ddl' one is apparently not quite fixed  - I get this in (cd 
contrib; make check)' (in both assert-enabled and non-assert-enabled 
build)

grep -A7 -B7 make.check_contrib.out:

contrib/make.check_contrib.out-============== initializing database 
system           ==============
contrib/make.check_contrib.out-============== starting postmaster        
             ==============
contrib/make.check_contrib.out-running on port 64464 with PID 9175
contrib/make.check_contrib.out-============== creating database 
"contrib_regression" ==============
contrib/make.check_contrib.out-CREATE DATABASE
contrib/make.check_contrib.out-ALTER DATABASE
contrib/make.check_contrib.out-============== running regression test 
queries        ==============
contrib/make.check_contrib.out:test ddl                          ... 
FAILED      840 ms
contrib/make.check_contrib.out-test xact                         ... ok  
          24 ms
contrib/make.check_contrib.out-test rewrite                      ... ok  
         187 ms
contrib/make.check_contrib.out-test toast                        ... ok  
         851 ms
contrib/make.check_contrib.out-test permissions                  ... ok  
          26 ms
contrib/make.check_contrib.out-test decoding_in_xact             ... ok  
          31 ms
contrib/make.check_contrib.out-test decoding_into_rel            ... ok  
          25 ms
contrib/make.check_contrib.out-test binary                       ... ok  
          12 ms

Otherwise patches apply and build OK so will go run some tests...