Re: improvements in Unicode tables generation code

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-10-04T18:36:32Z
Lists: pgsql-hackers
On 28.09.21 10:25, Peter Eisentraut wrote:
> 
> On 20.07.21 13:57, Peter Eisentraut wrote:
>>>> Perhaps we should change the script or Makefile so that it doesn't 
>>>> create all the maps in one go?
>>>
>>> I agree, either comment it better or just write one file at a time. 
>>> I'll take another look at that.
>>
>> Here is a patch that does it one file (pair) at a time.  The other 
>> rules besides UCS_to_most.pl actually had the same problem, since they 
>> produce two output files, so running in parallel called each script 
>> twice.  In this patch, all of that is heavily refactored and works 
>> correctly now. Note that UCS_to_most.pl already accepted a 
>> command-line argument to specify which encoding to work with.
> 
> Here is an updated patch with a thinko fix that made the previous patch 
> not actually work.

I have committed this one and closed the CF entry.



Commits

  1. Make Unicode makefile parallel-safe

  2. Remove some whitespace in generated C output

  3. Make UCS_to_most.pl process encodings in sorted order