Re: patch for parallel pg_dump
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Joachim Wieland <joe@mcknight.de>, Alvaro Herrera <alvherre@commandprompt.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2012-04-03T15:38:20Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Tue, Apr 3, 2012 at 10:40 AM, Joachim Wieland <joe@mcknight.de> wrote: >> I completely agree. Assertions helped a lot dealing with concurrent >> code. How do you want to tackle this for now? Want me to create a >> separate header pg_assert.h as part of my patch? Or is it okay to >> factor it out later and include it from the general header then? > I'll just go do it, barring objections. If the necessary support code isn't going to be available *everywhere*, it should not be in postgres.h. So I did not care for your proposal to put it in dumputils. Possibly we could move assert.c into src/port/ and make it part of libpgport? regards, tom lane