Horton

Thread

Commits

  1. pgbench: Remove now-dead CState->ecnt

  1. [PATCH] pgbench: Remove ecnt, a member variable of CState

    miyake_kouta <miyake_kouta@oss.nttdata.com> — 2021-02-26T08:39:31Z

    Hi.

I created a patch to remove ecnt which is a member variable of CState.
This variable is incremented in some places, but it's not used for any 
purpose.
Also, the current pgbench's client abandons processing after hitting 
error, so this variable is no need, I think.

Regards
--
Kota Miyake

  2. Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

    Michael Paquier <michael@paquier.xyz> — 2021-02-26T11:39:25Z

    On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:
> Also, the current pgbench's client abandons processing after hitting error,
> so this variable is no need, I think.

Agreed.  Its last use was in 12788ae, as far as I can see.  So let's
just cleanup that.
--
Michael

  3. Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2021-02-26T19:36:41Z

    On 2021-Feb-26, Michael Paquier wrote:

> On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:
> > Also, the current pgbench's client abandons processing after hitting error,
> > so this variable is no need, I think.
> 
> Agreed.  Its last use was in 12788ae, as far as I can see.  So let's
> just cleanup that.

+1

-- 
Álvaro Herrera       Valdivia, Chile

  4. Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

    Michael Paquier <michael@paquier.xyz> — 2021-02-27T23:06:09Z

    On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:
> +1

Thanks, done.
--
Michael

  5. Re: [PATCH] pgbench: Remove ecnt, a member variable of CState

    miyake_kouta <miyake_kouta@oss.nttdata.com> — 2021-03-01T02:32:11Z

    2021-02-28 08:06, Michael Paquier wrote:
> On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:
>> +1
> 
> Thanks, done.
> --
> Michael

Thanks for reviewing and committing this patch!

Regards
--
Kota Miyake