Horton
Menu

Re: pg_get__*_ddl consolidation

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>, Jeff Davis <pgsql@j-davis.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Japin Li <japinli@hotmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>, Euler Taveira <euler@eulerto.com>, Álvaro Herrera <alvherre@kurilemu.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-14T22:52:04Z
Lists: pgsql-hackers 
On 2026-04-13 Mo 3:41 PM, SATYANARAYANA NARLAPURAM wrote:
> Hi,
>
> On Fri, Apr 10, 2026 at 1:03 PM Jeff Davis <pgsql@j-davis.com> wrote:
>
>     On Sun, 2026-04-05 at 11:06 -0400, Andrew Dunstan wrote:
>     > Pushed. I have moved the remaining get_*_ddl items to PG20-1
>
>     The line:
>
>       role_settings = DatumGetArrayTypeP(datum);
>
>     should be DatumGetArrayTypePCopy(), because it's being pfree()d later.
>     The existing code will sometimes make a copy and sometimes not, e.g.:
>
>       -- settings are contrived to make the datum inline
>       CREATE USER u1;
>       ALTER ROLE u1 SET search_path = 'public, pg_catalog, pg_temp';
>       ALTER ROLE u1 SET work_mem='64MB';
>       ALTER ROLE u1 SET statement_timeout='30s';
>       ALTER ROLE u1 SET lock_timeout='10s';
>       ALTER ROLE u1 SET idle_in_transaction_session_timeout = '60s';
>       SELECT pg_get_role_ddl('u1');
>       ERROR:  pfree called with invalid pointer 0x7986dd0c7cc8 (header
>     0x0000400600000000)
>
>
> Yes, it appears to be a bug. Attached a patch to fix this. Tested with 
> the
> attached patch and don't see server crashing after that.
>
>

Thanks, pushed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use named boolean parameters for pg_get_*_ddl option arguments

  2. Convert ddlutils regression tests to TAP tests.

  3. Fix pfree crash in pg_get_role_ddl() and pg_get_database_ddl().

  4. Fixups for a4f774cf1c7

  5. Add infrastructure for pg_get_*_ddl functions

  6. Add pg_get_database_ddl() function

  7. Add pg_get_role_ddl() function

  8. Add pg_get_tablespace_ddl() function