Re: RFC: Additional Directory for Extensions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>, Craig Ringer <craig.ringer@enterprisedb.com>, "David E. Wheeler" <david@justatheory.com>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-03-19T18:55:58Z
Lists: pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> Committed that, thanks.

Buildfarm member snakefly doesn't like this too much.  Since no other
animals have failed, I guess it must be about local conditions on
that machine, but the report is pretty opaque:

# +++ tap check in src/test/modules/test_extensions +++

#   Failed test '$system extension is installed correctly on pg_available_extensions'
#   at t/001_extension_control_path.pl line 69.
#          got: 'f'
#     expected: 't'

#   Failed test '$system extension is installed correctly on pg_available_extensions with empty extension_control_path'
#   at t/001_extension_control_path.pl line 76.
#          got: 'f'
#     expected: 't'
# Looks like you failed 2 tests of 5.
[06:43:53] t/001_extension_control_path.pl .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/5 subtests

Looking at the test, it presupposes that "amcheck" must be an
available extension.  I do not see anything that guarantees
that that's so, though.  It'd fail if contrib hasn't been
installed.  Is there a reason to use "amcheck" rather than
something more certainly available, like "plpgsql"?

			regards, tom lane



Commits

  1. doc: Flesh out extension docs for the "prefix" make variable

  2. Fix extension control path tests

  3. extension_control_path