Re: very long record lines in expanded psql output
Platon Pronko <platon7pronko@gmail.com>
From: Platon Pronko <platon7pronko@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-03T12:57:33Z
Lists: pgsql-hackers
Attachments
- fix-header-lines-in-expanded-output.patch (text/x-patch) patch
On 2021-09-24 14:42, Andrew Dunstan wrote: > > On 9/24/21 12:49 AM, Platon Pronko wrote: >> On 2021-09-23 22:28, Andrew Dunstan wrote: >>> >>> 2. It would possibly be better to pass the relevant parts of the options >>> to print_aligned_vertical_line() rather than the whole options >>> structure. It feels odd to pass both that and opt_border. >> >> What do you think about doing it the other way around - passing only >> whole >> options structure? That way we will roll 4 parameters (opt_border, >> printTextFormat, >> and two xheader ones) into only one argument. >> This increases code coupling a bit, but I'm not sure if that's >> relevant here. >> > > Sure, as long as it doesn't result in duplicated computation. Hi! Please find attached the updated patch - with fixed braces and adjusted parameters to print_aligned_vertical_line(). Best regards, Platon Pronko
Commits
-
psql: Tweak xheader_width and pager_min_lines input parsing
- ed7e686a031e 16.0 landed
-
Add xheader_width pset option to psql
- a45388d6e098 16.0 landed