Re: new heapcheck contrib module

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>

Cc: Peter Geoghegan <pg@bowt.ie>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-10-22T03:45:08Z

Lists: pgsql-hackers

Attachments

v20-0001-Adding-function-verify_heapam-to-amcheck-module.patch (application/octet-stream) patch v20-0001
v20-0002-Adding-contrib-module-pg_amcheck.patch (application/octet-stream) patch v20-0002
v20-0003-Creating-non-throwing-interface-to-clog-and-slru.patch (application/octet-stream) patch v20-0003
v20-0004-Using-non-throwing-clog-interface-from-amcheck.patch (application/octet-stream) patch v20-0004
v20-0005-Adding-ACL-checks-for-verify_heapam.patch (application/octet-stream) patch v20-0005
(unnamed) (text/plain)


> On Oct 21, 2020, at 1:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Robert Haas <robertmhaas@gmail.com> writes:
>> I was about to commit 0001, after making some cosmetic changes, when I
>> discovered that it won't link for me. I think there must be something
>> wrong with the NLS stuff. My version of 0001 is attached. The error I
>> got is:
> 
> Well, the short answer would be "you need to add
> 
> SHLIB_LINK += $(filter -lintl, $(LIBS))
> 
> to the Makefile".  However, I would vote against that, because in point
> of fact amcheck has no translation support, just like all our other
> contrib modules.  What should likely happen instead is to rip out
> whatever code is overoptimistically expecting it needs to support
> translation.

Done that way in the attached, which also include Robert's changes from v19 he posted earlier today.

Commits

Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Generalize parallel slot result handling.
- 418611c84d00 14.0 landed
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
- e955bd4b6c2b 14.0 landed
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 landed
Doc: clean up verify_heapam() documentation.
- 4c49d8fc15ee 14.0 landed
Fix more portability issues in new amcheck code.
- 321633e17b07 14.0 landed
Fix portability issues in new amcheck test.
- 860593ec3bd1 14.0 landed
Try to avoid a compiler warning about using fxid uninitialized.
- 8bb0c9770e80 14.0 landed
Extend amcheck to check heap pages.
- 866e24d47db1 14.0 landed
Adjust walsender usage of xlogreader, simplify APIs
- 850196b610d2 13.0 cited
Improve checking of child pages in contrib/amcheck.
- d114cc538715 13.0 cited
Sanitize line pointers within contrib/amcheck.
- a9ce839a3137 12.0 cited
Fix possible sorting error when aborting use of abbreviated keys.
- 008c4135ccf6 10.0 cited