Re: Fix a typo in pg_rotate_logfile
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-02-12T20:39:06Z
Lists: pgsql-hackers
> On 12 Feb 2024, at 21:32, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c > - the hint message wrongly mentions that pg_logfile_rotate is part of > the core; which is actually not. pg_logfile_rotate is an adminpack's > 1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile > SQL function instead, so use that. Here's a patch to fix the typo. Nice catch! This needs to be backpatched all the way down to 12 as that function wen't away a long time ago (it was marked as deprecated all the way back in 9.1). -- Daniel Gustafsson
Commits
-
Remove the adminpack contrib extension
- cc09e6549f2b 17.0 landed