Re: relation OID in ReorderBufferToastReplace error message

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeremy Schneider <schnjere@amazon.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-07-02T01:56:40Z
Lists: pgsql-hackers
Jeremy Schneider <schnjere@amazon.com> writes:
> Nonetheless, in the process of troubleshooting it occurred to me that
> this error message would be more useful in general if it included the
> base relation OID in the error message. Amit suggested a separate thread
> - so here we are.  :)
> Anyone have thoughts?  Would I need a commitfest entry to propose a
> two-line tweak like this?

Probably not, unless it slips through the cracks.  But I wonder why
print the parent's OID, when we have access to its name.

			regards, tom lane



Commits

  1. Back-patch "Add parent table name in an error in reorderbuffer.c."

  2. Add parent table name in an error in reorderbuffer.c.

  3. Fix reorder buffer memory accounting for toast changes.

  4. Add logical change details to logical replication worker errcontext.

  5. Fix toast rewrites in logical decoding.

  6. Add error codes to some corruption log messages