Re: Unable to compile postgres 13.1 on Slackware current x64

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Condor <condor@stz-bg.com>, "pgsql-generallists.postgresql.org" <pgsql-general@lists.postgresql.org>
Date: 2020-11-16T17:30:03Z
Lists: pgsql-general
Thomas Munro <thomas.munro@gmail.com> writes:
> It looks like something happened to ICU's boolean macros .  See this
> commit in FreeBSD ports:

> https://github.com/freebsd/freebsd-ports/commit/81a88b4506ec06d07be10d199170ef4003eb0e30

It'd be so nice if people would tell us about their problems, instead of
just hacking-and-slashing.

In this case, I see one use of the constant TRUE in collationcmds.c,
but I wonder how come that's there given that we deprecated upper-case
TRUE some time ago.  I find it hard to believe that sprinkling "#include
<stdbool.h>" into random places is either necessary (on modern platforms
anyway) or a good idea (if we're not using <stdbool.h>, this seems pretty
much guaranteed to break things); so I think the rest of that patch is
foolhardy.

			regards, tom lane



Commits

  1. Use "true" not "TRUE" in one ICU function call.

  2. Change TRUE/FALSE to true/false