Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Mark Dilger <mark.dilger@enterprisedb.com>

Cc: Pavel Borisov <pashkin.elfe@gmail.com>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Peter Geoghegan <pg@bowt.ie>

Date: 2021-03-01T20:23:24Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Optimize speed of checking for unique constraint violation
- cdd6ab9d1f53 18.0 landed
amcheck: Report an error when the next page to a leaf is not a leaf
- 97e5b0026fc2 17.0 landed
amcheck: Don't load the right sibling page into BtreeCheckState
- 0b5c16124811 17.0 landed
amcheck: Refactoring the storage of the last visible entry
- 532d94fec32a 17.0 landed
Teach contrib/amcheck to check the unique constraint violation
- 5ae2087202af 17.0 landed
Add macros in hash and btree AMs to get the special area of their pages
- d16773cdc862 15.0 cited

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> Yes, my review was of v2.  Updating to v3, I see that the test passes on my laptop.  It still looks brittle to have all the tid values in the test output, but it does pass.

Hm, anyone tried it on 32-bit hardware?

			regards, tom lane