Re: Error code missing for "wrong length of inner sequence" error
Heikki Linnakangas <hlinnaka@iki.fi>
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-10-02T15:34:26Z
Lists: pgsql-hackers
On 02/10/2020 15:06, Daniel Gustafsson wrote: >> On 2 Oct 2020, at 13:44, Heikki Linnakangas <hlinnaka@iki.fi> wrote: >> >> On 01/10/2020 14:21, Daniel Gustafsson wrote: >>> On that note, wouldn't the dimension check errors in PLySequence_ToArray be >>> just as well off using normal ereport()'s? Only one of them seem to error out >>> in a way that could propagate an error from Python to postgres. >> >> Yes, you are right. I was going to say that we are not very >> consistent on when to use ereport() and when PLy_elog() in general, >> but looking closer, we are. Outside the array-conversion functions, >> PLy_elog() is only used when a Python C API call fails, and >> ereport() is used otherwise. > > I did another scan as well and couldn't find any other offenders. Pushed. Thanks for checking! - Heikki
Commits
-
Tidy up error reporting when converting PL/Python arrays.
- 26b8361518c3 14.0 landed