Re: Remove MSVC scripts from the tree

On 2023-12-20 We 08:31, Daniel Gustafsson wrote:
>> On 20 Dec 2023, at 01:48, Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Mon, Nov 20, 2023 at 05:03:28PM +0900, Michael Paquier wrote:
>>> Your suggestion to create a new sect2 for "Windows" as much as Andres'
>>> suggestion are OK by as an intermediate step, and I suspect that the
>>> end result will likely not be that.
>> It took me some time to get back to this one, and just applied the
>> patch removing the scripts.
> The Buildfarm complains that Win32::Registry can't be found:
>
> Can't locate Win32/Registry.pm in @INC (you may need to install the Win32::Registry module) (@INC entries checked: src/test/perl src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line 21.
> BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21.
>
> https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-12-20%2013%3A19%3A04
>
> This could perhaps be related to this patch removing the module in
> src/tools/msvc/dummylib/Win32/Registry.pm ?
>


It is. I've fixed the buildfarm to stop checking this script.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com