Horton

Re: Add log_autovacuum_{vacuum|analyze}_min_duration

kasaharatt <kasaharatt@oss.nttdata.com>

View thread
From: kasaharatt <kasaharatt@oss.nttdata.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, wenhui qiu <qiuwenhuifx@gmail.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Nathan Bossart <nathandbossart@gmail.com>, Michael Banck <mbanck@gmx.net>, pgsql-hackers@postgresql.org
Date: 2025-08-13T08:44:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add log_autoanalyze_min_duration

  2. Generate GUC tables from .dat file

Hi,

2025-07-02 15:37 に Shinya Kato wrote:
> On Mon, Jun 23, 2025 at 4:24 PM Shinya Kato <shinya11.kato@gmail.com> 
> wrote:
>> 
>> On Wed, Jun 11, 2025 at 1:49 PM Shinya Kato <shinya11.kato@gmail.com> 
>> wrote:
>>> 
>>> On Thu, Jun 5, 2025 at 3:53 AM Sami Imseih <samimseih@gmail.com> 
>>> wrote:
>>>> 
>>>> > Approach 2:
>>>> > - log_autovacuum_min_duration: Changed behavior, which controls only
>>>> > autovacuum logging.
>>>> > - log_autoanalyze_min_duration: New parameter, which controls
>>>> > autoanalyze logging.
>>>> 
>>>> My vote is for this approach. It is probably OK to change the 
>>>> behavior of
>>>> log_autovacuum_min_duration, as the new GUC will have the same 
>>>> default
>>>> value.
>>> 
>>> 
>>> Thank you for voting. I also think this approach is reasonable to 
>>> implement.
>> 
>> 
>> A new patch is attached.
>> Thoughts?
I reviewed this patch.
I also have no particular objections to the Approach 2.

> +    <term><literal>log_autoanalyze_min_duration</literal>, 
> <literal>toast.log_autoanalyze_min_duration</literal>(<type>integer</type>)
(snip)
> +       "toast.log_autoanalyze_min_duration",
This patch adds the log_autoanalyze_min_duration parameter fot TOAST 
tables.
However since PostgreSQL currently does not support ANALYZE on TOAST 
tables,
isn't this parameter unnecessary?

Best regards,
-- 
Kasahara Tatsuhito
NTT DATA Japan Corporation