Horton
Menu

Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, tushar <tushar.ahuja@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>
Date: 2022-06-03T16:55:28Z
Lists: pgsql-hackers 
> On 3 Jun 2022, at 18:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> Or we could revisit Tom's proposal in the thread that implemented the feature:
>> to have timestamped directory names to get around this very problem?  I think
>> we should be able to figure out a way to make it easy enough for the BF code to
>> figure out (and clean up).
> 
> How about inserting an additional level of subdirectory?
> 
> pg_upgrade_output.d/20220603122528/foo.log
> 
> Then code doing "rm -rf pg_upgrade_output.d" needs no changes.

Off the cuff that seems like a good compromise.  Adding Andrew on CC: for input
on how that affects the buildfarm.

--
Daniel Gustafsson		https://vmware.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Restructure pg_upgrade output directories for better idempotence