Horton

Re: Improve the connection failure error messages

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Nisha Moond <nisha.moond412@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-04-26T07:40:27Z
Lists: pgsql-hackers 
> On 22 Mar 2024, at 11:42, Nisha Moond <nisha.moond412@gmail.com> wrote:

> Here is the v4 patch with changes required in slotfuncs.c and slotsync.c files.

-	errmsg("could not connect to the primary server: %s", err));
+	errmsg("\"%s\" could not connect to the primary server: %s", app_name.data, err));

Messages like this should perhaps have translator comments to indicate what the
leading "%s" will contain?

--
Daniel Gustafsson

Commits

  1. Improve logical replication connection-failure messages.

  2. Fix a random failure in 038_save_logical_slots_shutdown.pl.

  3. Add a failover option to subscriptions.