Horton

Re: Add reject_limit option to file_fdw

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Yugo NAGATA <nagata@sraoss.co.jp>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-27T14:45:23Z
Lists: pgsql-hackers 

On 2024/11/21 15:43, torikoshia wrote:
> Thanks for the update! Agreed.
> I think the validator tests related to the on_error option you added are sufficient.

I've pushed the patch. Thanks!

> As for the other file_fdw options, I'm a bit concerned whether it would be better to add validator tests for cases like when 'encoding' is 'unsupported', but that should be discussed in another thread.

I'm not sure how valuable it is to add that test, but yes,
it would be better to start a new thread for discussion if needed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. file_fdw: Add regression tests for ON_ERROR and other options.

  2. file_fdw: Add REJECT_LIMIT option to file_fdw.