Re: Memoize ANTI and SEMI JOIN inner

Andrei Lepikhov <lepihov@gmail.com>

From: Andrei Lepikhov <lepihov@gmail.com>

To: wenhui qiu <qiuwenhuifx@gmail.com>, Richard Guo <guofenglinux@gmail.com>

Cc: David Rowley <dgrowleyml@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2025-07-02T09:01:39Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Enable use of Memoize for ANTI joins
- 0da29e4cb161 19 (unreleased) landed

On 2/7/2025 05:48, wenhui qiu wrote:
> HI
> 
>  > - if (!extra->inner_unique && (jointype == JOIN_SEMI ||
>  > - jointype == JOIN_ANTI))
>  > + if ((jointype == JOIN_SEMI || jointype == JOIN_ANTI) &&
>  > + !extra->inner_unique)
> To be nitpicky, this change is meant to align with the earlier comment 
> modifications to improve code readability, right? Everything else looks 
> good to me."
Yep, I also found only this flaw.
Comments looks clear to me, test is quite stable.

May be correct the line:
INSERT INTO tab_anti SELECT i%3, false FROM generate_series(1,100)i;
with a backspace or an 'AS' keyword?

-- 
regards, Andrei Lepikhov