Re: Emacs vs pg_indent's weird indentation for function declarations
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-28T05:28:30Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes: > For a while I've been baffled by that: the first arguments of later > lines don't line up with that of the first line, but they're also not > in a constant column (it varies from function to function), and it's > also not caused by 8-space vs 4-space confusion. It was only when I > put those two things next to each other just now in this email that I > finally spotted the logic it's using: if you remove "extern int " then > the later lines line up with the first argument of the top line. This > works for other examples I looked at too. Huh. Yeah. I suspect that the underlying cause is that pgindent doesn't really distinguish function declarations from definitions, at least not when it comes time to indent the lines after the first one. > That's ... annoying. I wish indent wouldn't do that, because it means > that my declarations get moved around every time I write code. If you can fix it, I'd vote for accepting the patch. I don't personally have the desire to dig into the indent code that much ... regards, tom lane
Commits
-
Phase 2 pgindent run for v12.
- 8255c7a5eeba 12.0 landed
-
ANSI-ify a few straggler K&R-style function definitions.
- da71f98efba9 12.0 landed