Horton

Re: Index only scan for cube and seg

x4mmm@yandex-team.ru

View thread View on postgr.es
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-10-29T08:38:43Z
Lists: pgsql-hackers

Attachments

Hi!
> 29 окт. 2017 г., в 2:24, Alexander Korotkov <a.korotkov@postgrespro.ru> написал(а):
> 
> As I can see, cube GiST code always uses DatumGetNDBOX() macro to transform Datum to (NDBOX *).
> 
> #define DatumGetNDBOX(x)	((NDBOX *) PG_DETOAST_DATUM(x))
> 
> Thus, it should be safe to just remove both compress/decompress methods from existing opclass.

Alexander, Tom, you are absolutely right. I was sure there is toasting code in cube's compress, but it was not ever there.

Here is patch for cube that drops functions.

Best regards, Andrey Borodin.

Commits

  1. Support index-only scans in contrib/cube and contrib/seg GiST indexes.