Horton

Re: Rework of collation code, extensibility

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Jeff Davis <pgsql@j-davis.com>, Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@postgresql.org
Date: 2023-02-22T19:49:15Z
Lists: pgsql-hackers 
On 14.02.23 00:45, Jeff Davis wrote:
> Now the patches are:
> 
>      0001: pg_strcoll/pg_strxfrm
>      0002: pg_locale_deterministic()
>      0003: cleanup a USE_ICU special case
>      0004: GUCs (only for testing, not for commit)

I haven't read the whole thing again, but this arrangement looks good to 
me.  I don't have an opinion on whether 0004 is actually useful.

Commits

  1. Remove unnecessary #ifdef USE_ICU and branch.

  2. Refactor to introduce pg_locale_deterministic().

  3. Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

  4. Fix MSVC build