Horton

Re: Rework of collation code, extensibility

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Jeff Davis <pgsql@j-davis.com>, Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@postgresql.org
Date: 2023-01-31T10:40:49Z
Lists: pgsql-hackers 
On 27.01.23 00:47, Jeff Davis wrote:
> I'm hoping to commit 0002 and 0003 soon-ish, maybe a week or two,
> please let me know if you want me to hold off. (I won't commit the GUCs
> unless others find them generally useful; they are included here to
> more easily reproduce my performance tests.)

I have looked a bit at 0002 and 0003.  I like the direction.  I'll spend 
a bit more time reviewing it in detail.  It moves a lot of code around.

I don't know to what extent this depends on the abbreviated key GUC 
discussion.  Does the rest of this patch set depend on this?

Commits

  1. Remove unnecessary #ifdef USE_ICU and branch.

  2. Refactor to introduce pg_locale_deterministic().

  3. Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

  4. Fix MSVC build