Horton

RE: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT

Huong Dangminh <huo-dangminh@ys.jp.nec.com>

View thread View on postgr.es
From: Huong Dangminh <huo-dangminh@ys.jp.nec.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan Allen <jallen@americansavingslife.com>, Michael Meskes <meskes@postgresql.org>, Andrew Gierth <andrew@tao11.riddles.org.uk>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, "Akio Iwaasa" <aki-iwaasa@vt.jp.nec.com>
Date: 2018-05-18T05:21:31Z
Lists: pgsql-bugs

Attachments

> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> It seems fairly unfortunate that this patch does not fix the problem for
> as far back as MSVC has "long long" support.  From what I can tell, we could
> use _strtoi64 and _strtoui64 on older Windows versions.  

Thanks. You are right.
We also should fix for older VS too.

> something like
> 
> #if (_MSC_VER > 1200)
> #define HAVE_LONG_LONG_INT_64 1
> #endif
> 
> ...
> 
> #ifdef HAVE_LONG_LONG_INT_64
> #define HAVE_STRTOLL 1
> /* Before VS2013, use Microsoft's nonstandard equivalent function */ #if
> (_MSC_VER < 1800) #define strtoll _strtoi64 #endif #endif
> 
> and similarly for strtoull.
> 
> Please check that and see if it works.

Thanks, as you mentioned the attached works fine for me.
I think the code is also fine for the before VS2013 but I not yet tested.

> BTW, is it possible to set up an ecpg test case to verify that this stuff
> works?
> It'd have to handle platforms without long long though, so I'm not
> sure how to deal with that.

Yes. I was expecting that at least bigint will works fine with sqlda in linux 
system but it seem did not?
Attached test patch works fine in Windows, but in Linux system 
the sqlda->sqlvar[i].sqltype return ECPGt_long but not ECPGt_long_long (as expected) 
when reference to bigint column.
Is this another problem in linux? Or am I wrong something?


Thanks and best regards,
---
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

Commits

  1. Remove configure's check for nonstandard "long long" printf modifiers.

  2. printf("%lf") is not portable, so omit the "l".

  3. Support platforms where strtoll/strtoull are spelled __strtoll/__strtoull.

  4. Arrange to supply declarations for strtoll/strtoull if needed.

  5. Hot-fix ecpg regression test for missing ecpg_config.h inclusion.

  6. Add some test coverage for ecpg's "long long" support.

  7. Recognize that MSVC can support strtoll() and strtoull().

  8. Fix up ecpg's configuration so it handles "long long int" in MSVC builds.