Running make check-world in buildfarm (was Re: [COMMITTERS] pgsql: Use SASLprep to normalize passwords for SCRAM authentication.)

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-04-08T10:33:41Z
Lists: pgsql-hackers
On 04/08/2017 04:23 AM, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
>> Use SASLprep to normalize passwords for SCRAM authentication.
>
> The test script that this adds appears to fail unless the environment
> selects a UTF8-based locale.  On my RHEL6 machine, I see:
>
> LANG=C make check			fail
> LANG=en_US.iso88591 make check		fail
> LANG=en_US.utf8 make check		ok

Fixed, thanks!

> I'm surprised that more of the buildfarm hasn't fallen over.

Hmm. It looks like none of the buildfarm members are running the 
authentication tests. Nor recovery tests, nor subscription tests. We're 
missing a trick here, at least some of the buildfarm members really 
ought to run "make check-world", we're missing a lot of coverage otherwise.

- Heikki



Commits

  1. Fix the new SASLprep tests to work with non-UTF-8 locales.

  2. Use SASLprep to normalize passwords for SCRAM authentication.