Re: Increase pltcl test coverage
Jim Nasby <jim.nasby@bluetreble.com>
From: Jim Nasby <Jim.Nasby@BlueTreble.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>,
Karl Lehenbauer <karl@flightaware.com>
Date: 2017-01-08T00:13:31Z
Lists: pgsql-hackers
Attachments
- pltcl_coverage_2.patch (text/plain) patch
- (unnamed) (text/plain)
On 1/6/17 2:17 PM, Tom Lane wrote: > Jim Nasby <Jim.Nasby@BlueTreble.com> writes: >> On 10/31/16 3:24 PM, Jim Nasby wrote: >>> This patch increases test coverage for pltcl, from 70% to 83%. Aside >>> from that, the work on this uncovered 2 new bugs (the trigger return one >>> I just submitted, as well as a bug in the SRF/composite patch). > >> Rebased patch attached. Test coverage is now at 85% (by line count). > > This is in a format that neither patch(1) nor "git apply" recognize. > Please resubmit in a more usual format, diff -c or diff -u perhaps. Odd, dunno what happened there. New patch attached. BTW, this also includes some case changes back to lowercase. My muscle memory would prefer to go the other direction but I figured consistency was worth something. Feel free not to include that bit if you want. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com 855-TREBLE2 (855-873-2532)
Commits
-
Expand the regression tests for PL/Tcl.
- 961bed020891 10.0 landed