Horton

Re: pgsql: dshash: Add sequential scan support.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Date: 2022-03-11T01:09:56Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> dshash: Add sequential scan support.
> Add ability to scan all entries sequentially to dshash. The interface is
> similar but a bit different both from that of dynahash and simple dshash
> search functions. The most significant differences is that dshash's interfac
> always needs a call to dshash_seq_term when scan ends.

Umm ... what about error recovery?  Or have you just cemented the
proposition that long-lived dshashes are unsafe?

			regards, tom lane

Commits

  1. Fix lock assertions in dshash.c.

  2. dshash: Add sequential scan support.