Re: Move OpenSSL random under USE_OPENSSL_RANDOM
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Daniel Gustafsson <daniel@yesql.se>,
Michael Paquier <michael@paquier.xyz>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-16T15:06:00Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > I agree with those -- either we remove the ability to choose random source > independently of the SSL library (and then only use the windows crypto > provider or /dev/urandom as platform-specific choices when *no* SSL library > is used), and in that case we should not have separate #ifdef's for them. > Or we fix the includes. Which is obviously easier, but we should take the > time to do what we think is right long-term of course. FWIW, I'd vote for the former. I think the presumption that OpenSSL's random-number machinery can be used without any other initialization is shaky as heck. regards, tom lane
Commits
-
Remove ability to independently select random number generator
- 16f96c74d48e 14.0 landed
-
Add pg_strong_random_init function to initialize random number generator
- 5ee180a39470 14.0 landed