Horton

Re: BUG #16476: pgp_sym_encrypt_bytea with compress-level=6 : Wrong key or corrupt data

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, jeff.janes@gmail.com, frank.gagnepain@intm.fr, pgsql-bugs@lists.postgresql.org, Mark Wong <mark@2ndquadrant.com>
Date: 2020-07-22T14:39:43Z
Lists: pgsql-bugs 
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jul 22, 2020 at 05:45:54PM +0900, Kyotaro Horiguchi wrote:
>> Might be help if the test prints the orignal and the decrypted bytes?

> And turning the buildfarm completely red?  No, thanks.  Those random
> strings are also too long to be analyzed easily.

Is there a reason why the test string has to be non-constant?
The current form of the test would be fine if things were working,
but it offers absolutely zero chance of diagnosing problems.
For starters, it'd be nice to know whether the encrypt or the
decrypt side is going wrong.

			regards, tom lane

Commits

  1. Fix corner case with 16kB-long decompression in pgcrypto, take 2

  2. Fix ancient violation of zlib's API spec.

  3. Revert "Fix corner case with PGP decompression in pgcrypto"

  4. Fix corner case with PGP decompression in pgcrypto