Horton

Re: Fixing MSVC's inability to detect elog(ERROR) does not return

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2026-07-05T15:18:28Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> Now pushed and awaiting buildfarm feedback.

It came to my attention just now that 59c2f03d1 adjusted ereport()
to be MSVC-friendly, but did not touch plpy_elog.h's PLy_elog(),
which has a borrowed copy of the same logic.  Was that intentional?
It seems like we should keep those looking alike.

			regards, tom lane

Commits

  1. Rename pg_builtin_integer_constant_p to pg_integer_constant_p

  2. Teach MSVC that elog/ereport ERROR doesn't return