Horton

Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <jchampion@timescale.com>, Peter Eisentraut <peter@eisentraut.org>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-06-30T07:42:13Z
Lists: pgsql-hackers 
> On 30 Jun 2023, at 09:09, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Thu, Jun 29, 2023 at 09:05:59AM -0700, Jacob Champion wrote:
>> Sounds good -- 0002 can be ignored as needed, then. (Or I can resend a
>> v3 for CI purposes, if you'd like.)
> 
> I am assuming that this is 0001 posted here:
> https://www.postgresql.org/message-id/8be3d35a-9608-b1d5-e5e6-7a744ea45fef@timescale.com
> 
> And that looks OK to me.  This is something I'd rather backpatch down
> to v11 on usability ground for developers.  Any comments or objections
> about that?

Agreed, I'd prefer all branches to work the same for this.

Reading the patch, only one thing stood out:

-variable PG_TEST_NOCLEAN is set, data directories will be retained
-regardless of test status.
+variable PG_TEST_NOCLEAN is set, those directories will be retained

I would've written "the data directories" instead of "those directories" here.

--
Daniel Gustafsson

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests