Re: allow online change primary_conninfo
Sergei Kornilov <sk@zsrv.org>
From: Sergei Kornilov <sk@zsrv.org>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-02-16T11:50:35Z
Lists: pgsql-hackers
Attachments
- reload_walreceiver_conninfo_v005.patch (text/x-diff) patch v5
Hi > I don't quite think this is the right design. IMO the startup process > should signal the walreceiver to shut down, and the wal receiver should > never look at the config. Ok, i can rewrite such way. Please check attached version. > Otherwise there's chances for knowledge of > pg.conf to differ between the processes. I still not understood why this: - is not issue for startup process with all primary_conninfo logic - but issue for walreceiver with Michael Paquier patch; therefore without any primary_conninfo change logic in startup. In both cases primary_conninfo change logic is only in one process. regards, Sergei
Commits
-
Allow walreceiver configuration to change on reload
- 1e6148032e4d 13.0 landed