Horton

Re: DROP DATABASE is interruptible

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Evgeny Morozov <postgresql3@realityexists.net>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-07-14T08:35:42Z
Lists: pgsql-hackers 
> On 13 Jul 2023, at 22:52, Andres Freund <andres@anarazel.de> wrote:
> On 2023-07-12 11:54:18 +0200, Daniel Gustafsson wrote:

>> Looking more at this I wonder if we in HEAD should make this a bit nicer by
>> extending the --check phase to catch this?  I did a quick hack along these
>> lines in the 0003 commit attached here (0001 and 0002 are your unchanged
>> patches, just added for consistency and to be CFBot compatible).  If done it
>> could be a separate commit to make the 0002 patch backport cleaner of course.
> 
> I don't really have an opinion on that, tbh...

Fair enough.  Thinking more on it I think it has merits, so I will submit that
patch in its own thread on -hackers.

--
Daniel Gustafsson

Commits

  1. pg_dump: tests: Correct test condition for invalid databases

  2. Handle DROP DATABASE getting interrupted