Horton
Menu

Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Bruno Wolff III <bruno@wolff.to>, pgsql-bugs@postgresql.org
Date: 2017-06-23T00:35:55Z
Lists: pgsql-bugs, pgsql-hackers 
On 2017/06/23 2:22, Alvaro Herrera wrote:
> Amit Langote wrote:
>> On 2017/06/21 11:02, Alvaro Herrera wrote:
>>> Bruno Wolff III wrote:
>>>> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
>>>> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
>>>
>>> You're absolutely right, and this is a bug in the parser -- I probably
>>> misplaced the IF NOT EXISTS clause while playing with Tomas' parser
>>> changes.  Here's the fix.  I'm a bit troubled that this change doesn't
>>> seem to affect any tests, so I'll add some before pushing.
>>
>> I posted the same patch but with a test:
>>
>> https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp
> 
> Pushed.

Thanks, Alvaro.

Regards,
Amit

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix IF NOT EXISTS in CREATE STATISTICS