Horton

Thread

Commits

  1. Revision

  1. Check query

    The Post Office <noreply@postgresql.org> — 2026-06-26T14:37:56Z

    The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/18/rules-views.html
Description:

Please check that the condition in the query is correct.

> 39.2.1. How SELECT Rules Work

Similarly, the rules for shoe and shoelace are substituted into the range
table of the subquery, leading to a three-level final query tree:

SELECT shoe_ready.shoename, shoe_ready.sh_avail,
       shoe_ready.sl_name, shoe_ready.sl_avail,
       shoe_ready.total_avail
...
...
WHERE shoe_ready.total_avail > 2;  ??? (maybe WHERE shoe_ready.total_avail
>= 2;)

  2. Re: Check query

    David G. Johnston <david.g.johnston@gmail.com> — 2026-06-27T15:51:09Z

    On Friday, June 26, 2026, PG Doc comments form <noreply@postgresql.org>
wrote:

> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/rules-views.html
> Description:
>
> ...
> WHERE shoe_ready.total_avail > 2;  ??? (maybe WHERE shoe_ready.total_avail
> >= 2;)
>

Yes, the lack of an equal sign there is a typo.

David J.

  3. Re: Check query

    Fujii Masao <masao.fujii@gmail.com> — 2026-07-07T00:52:39Z

    On Sun, Jun 28, 2026 at 12:51 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Friday, June 26, 2026, PG Doc comments form <noreply@postgresql.org> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/18/rules-views.html
>> Description:
>>
>> ...
>> WHERE shoe_ready.total_avail > 2;  ??? (maybe WHERE shoe_ready.total_avail
>> >= 2;)
>
>
> Yes, the lack of an equal sign there is a typo.

Yes. Very old commit dcb00495236 seems to have accidentally changed
the condition to > 2 while rewriting the example to use SQL operator
notation.

The attached patch changes it from > 2 to >= 2.
Barring any objections, I'll backpatch it to all supported branches.

Regards,

-- 
Fujii Masao

  4. Re: Check query

    Daniel Gustafsson <daniel@yesql.se> — 2026-07-07T15:00:46Z

    > On 7 Jul 2026, at 02:52, Fujii Masao <masao.fujii@gmail.com> wrote:

> Yes. Very old commit dcb00495236 seems to have accidentally changed
> the condition to > 2 while rewriting the example to use SQL operator
> notation.
> 
> The attached patch changes it from > 2 to >= 2.
> Barring any objections, I'll backpatch it to all supported branches.

LGTM.  I reviewed the referenced commit to see if there were other similar
mistakes but found none.

--
Daniel Gustafsson

  5. Re: Check query

    Fujii Masao <masao.fujii@gmail.com> — 2026-07-08T00:08:43Z

    On Wed, Jul 8, 2026 at 12:01 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> LGTM.  I reviewed the referenced commit to see if there were other similar
> mistakes but found none.

Thanks for the review and check! I've pushed the patch.

Regards,

-- 
Fujii Masao