Re: make -C libpq check fails obscurely if tap tests are disabled
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrew Dunstan <andrew@dunslane.net>,
Justin Pryzby <pryzby@telsasoft.com>,
pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2022-07-22T20:40:43Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2022-Jul-22, Alvaro Herrera wrote: >> It's not very common -- we do have some target-specific variable >> assignments, but none of them use 'export'. I saw somewhere that this >> works from Make 3.77 onwards, and we require 3.80, so it should be okay. >> The buildfarm will tell us ... > Hm, so prairiedog didn't like this: > According to 32568.1536241083@sss.pgh.pa.us, prairiedog is on Make 3.80. Yeah, it is. I looked at the gmake manual on that machine, and its description of "export" seems about the same as what I see in a modern version. So it should work ... but we've found bugs in 3.80 before. Let me poke at it and see if there's a variant that works. The wording of the message suggests that maybe breaking it into two separate rules would help. regards, tom lane
Commits
-
Increase minimum supported GNU make version to 3.81.
- 8efefa748777 16.0 landed
- 3b474a2e660f 15.0 landed
-
Fix [install]check in interfaces/libpq/Makefile
- 1846202fe108 15.0 landed
- 0f39b70a6f36 16.0 landed
-
Run tap tests in src/interfaces/libpq.
- 6b04abdfc5e0 15.0 cited