Re: using index or check in ALTER TABLE SET NOT NULL

Sergei Kornilov <sk@zsrv.org>

From: Sergei Kornilov <sk@zsrv.org>

To: David Rowley <david.rowley@2ndquadrant.com>

Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Robert Haas <robertmhaas@gmail.com>, Ildar Musin <i.musin@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>

Date: 2019-03-10T11:13:17Z

Lists: pgsql-hackers

Attachments

0001_alter_table_set_not_null_v11.5.patch (text/x-diff) patch v11
0002_alter_table_set_not_null_v11_debuglevel_tests.patch (text/x-diff) patch v11

Hi

> Providing I'm imagining it correctly, I do think the patch is slightly
> cleaner with that change.

Ok, sounds reasonable. I changed patch this way.

regards, Sergei

Commits

Avoid using INFO elevel for what are fundamentally debug messages.
- db438318997b 13.0 landed
- 121e3ceed6d9 12.0 landed
Revert setting client_min_messages to 'debug1' in new tests.
- 5655565c077c 12.0 landed
Allow ALTER TABLE .. SET NOT NULL to skip provably unnecessary scans.
- bbb96c3704c0 12.0 landed
Improve predtest.c's internal docs, and enhance its functionality a bit.
- 5748f3a0aa7c 11.0 cited