Re: ICU for global collation

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

To: Marina Polyakova <m.polyakova@postgrespro.ru>

Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz

Date: 2022-10-01T12:07:29Z

Lists: pgsql-hackers

On 22.09.22 20:06, Marina Polyakova wrote:
> On 2022-09-21 17:53, Peter Eisentraut wrote:
>> Committed with that test, thanks.  I think that covers all the ICU
>> issues you reported for PG15 for now?
> 
> I thought about the order of the ICU checks - if it is ok to check that 
> the selected encoding is supported by ICU after printing all the locale 
> & encoding information, why not to move almost all the ICU checks here?..

It's possible that we can do better, but I'm not going to add things 
like that to PG 15 at this point unless it fixes a faulty behavior.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add CHECK_FOR_INTERRUPTS while restoring changes during decoding.
- ce20f8b9f435 16.0 cited
Improve ICU option handling in CREATE DATABASE
- e59a67fb8fe1 16.0 landed
- 865b52af6104 15.0 landed
Don't allow creation of database with ICU locale with unsupported encoding
- c7db01e325a5 16.0 landed
- 148f66d59e2c 15.0 landed
Make locale option behavior more consistent
- da5d4ea5aaac 16.0 landed
- 3e694b318d20 15.0 landed
pg_dump: Dump colliculocale
- 72b6828da3f7 15.0 landed
- 396d348b046c 16.0 landed
Remove further unwanted linker flags from perl_embed_ldflags
- b4e936859dc4 16.0 cited
Doc: document possible need to raise kernel's somaxconn limit.
- 2c63b0930aee 15.0 cited
Reduce warnings with -Wshadow=compatible-local builds
- 92fce4e1eda9 16.0 cited
Remove redundant spaces in _outA_Expr() output
- 1c5818b9c68e 16.0 cited
Fix outdated --help message for postgres -f
- 63b64d827069 14.6 cited
pg_upgrade: Fix version comparison for global ICU support
- fa06a34d14ea 15.0 landed
Silence -Wmaybe-uninitialized compiler warning in dbcommands.c.
- 97bddda61b9a 15.0 landed
Add option to use ICU as global locale provider
- f2553d43060e 15.0 landed
DefineCollation() code cleanup
- e94bb1473eb3 15.0 landed
Change collate and ctype fields to type text
- 54637508f87b 15.0 landed
Call pg_newlocale_from_collation() also with default collation
- b99ccd2cb217 15.0 landed
Use libc version as a collation version on glibc systems.
- d5ac14f9ccdd 13.0 cited
Silence -Wmaybe-uninitialized compiler warnings in dbcommands.c.
- 3f6b3be39ca9 13.0 cited
Make LC_COLLATE and LC_CTYPE database-level settings. Collation and
- 61d967498802 8.4.0 cited