Horton

Re: Missing deconstruct_array_builtin usage

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-10-14T10:05:18Z
Lists: pgsql-hackers 
On 14.10.24 08:12, Bertrand Drouvot wrote:
>> It seems that src/backend/utils/adt/float.c file still has functions
>> that can use [de]construct_array_builtin(), for example
>> float8_combine(). I think it's an oversight of d746021de1.
> Thanks for looking at it.
> 
> Good catch, please find attached v2 taking care of those. I looked at the
> remaining [de]construct_array() usages and that looks ok to me.

This looks good to me.  I can't think of a reason why it was not 
included in the original patch.

Commits

  1. Use construct_array_builtin for FLOAT8OID instead of construct_array.

  2. Use deconstruct_array_builtin instead of deconstruct_array