Horton
Menu

Re: Fix bug of clearing of waitStart in ProcWakeup()

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: ji xu <thanksgreed@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-26T01:04:01Z
Lists: pgsql-hackers 

> On Feb 26, 2026, at 08:08, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Wed, Feb 25, 2026 at 7:03 AM Chao Li <li.evan.chao@gmail.com> wrote:
>> 
>> 
>> 
>>> On Feb 24, 2026, at 23:41, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> 
>>> On Tue, Feb 24, 2026 at 4:31 PM ji xu <thanksgreed@gmail.com> wrote:
>>>> 
>>>> 
>>>> Chao Li <li.evan.chao@gmail.com> 于2026年2月24日周二 14:29写道：
>>>>> 
>>>>> Since this function is clearly operating on the parameter proc, the only statement that touches MyProc looks suspicious. It should reset proc->waitStart, not MyProc->waitStart.
>>>>> 
>>>>> As written, it will incorrectly clear the caller’s waitStart instead of the awakened backend’s, potentially leaving a stale waitStart value in the target PGPROC.
>>> 
>>> Thanks for the report!
>>> 
>> 
>> I just realized that I forgot to attach the patch file. Anyway, that’s just a one-line change.
> 
> I've pushed the patch. Thanks!
> 
> Regards,
> 
> -- 
> Fujii Masao

Hi Fujii-san, thank you very much for taking care of this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix ProcWakeup() resetting wrong waitStart field.