Re: [17] CREATE SUBSCRIPTION ... SERVER

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org

Date: 2024-01-24T01:45:07Z

Lists: pgsql-hackers

Attachments

v9-0001-Add-SQL-function-pg_conninfo_from_server.patch (text/x-patch) patch v9-0001
v9-0002-CREATE-SUSBCRIPTION-.-SERVER.patch (text/x-patch) patch v9-0002
v9-0003-Introduce-pg_create_connection-predefined-role.patch (text/x-patch) patch v9-0003

On Tue, 2024-01-23 at 15:21 +0530, Ashutosh Bapat wrote:
> I am with the prefix. The changes it causes make review difficult. If
> you can separate those changes into a patch that will help.

I ended up just removing the dummy FDW. Real users are likely to want
to use postgres_fdw, and if not, it's easy enough to issue a CREATE
FOREIGN DATA WRAPPER. Or I can bring it back if desired.

Updated patch set (patches are renumbered):

  * removed dummy FDW and test churn
  * made a new pg_connection_validator function which leaves
postgresql_fdw_validator in place. (I didn't document the new function
-- should I?)
  * included your tests improvements
  * removed dependency from the subscription to the user mapping -- we
don't depend on the user mapping for foreign tables, so we shouldn't
depend on them here. Of course a change to a user mapping still
invalidates the subscription worker and it will restart.
  * general cleanup

Overall it's simpler and hopefully easier to review. The patch to
introduce the pg_create_connection role could use some more discussion,
but I believe 0001 and 0002 are nearly ready.

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Document new catalog columns, missed in commit 8185bb5347.
- 90630ec42939 19 (unreleased) landed
Refactor to remove ForeignServerName().
- 11f8018ee678 19 (unreleased) landed
GetSubscription(): use per-object memory context.
- f16f5d608ca6 19 (unreleased) landed
Fix dependency on FDW's connection function.
- 4a0b46b6e1e4 19 (unreleased) landed
ALTER SUBSCRIPTION ... SERVER test.
- 1c5bf1185af0 19 (unreleased) landed
Fix pg_dump for CREATE FOREIGN DATA WRAPPER ... CONNECTION.
- b71bf3b84570 19 (unreleased) landed
Clean up postgres_fdw/t/010_subscription.pl.
- f4af7849b3db 19 (unreleased) landed
CREATE SUBSCRIPTION ... SERVER.
- 8185bb534763 19 (unreleased) landed
Allow upgrades to preserve the full subscription's state.
- 9a17be1e244a 17.0 cited