Re: Virtual generated columns
Peter Eisentraut <peter@eisentraut.org>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
-
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
-
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
-
Virtual generated columns
- 83ea6c54025b 18.0 landed
-
Additional tests for stored generated columns
- 41084409f635 18.0 landed
-
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
-
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
-
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
-
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
-
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
-
Small code simplification
- 7ff9afbbd1df 18.0 landed
-
Remove useless code
- e26d313bad92 18.0 landed
-
Remove useless initializations
- da2aeba8f533 18.0 landed
-
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
-
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
-
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited
On 13.11.24 04:30, jian he wrote:
> in
> transformColumnDefinition
> we can add parser_errposition for the error report.
> if (column->is_not_null && column->generated ==
> ATTRIBUTE_GENERATED_VIRTUAL)
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("not-null constraints are not supported on
> virtual generated columns"),
> parser_errposition(cxt->pstate,
> constraint->location)));
> sometimes, it points to the word "generated", sometimes "not". I guess
> this should be fine.
> example:
> create table t13 (a int, b bool generated always as ((true )) VIRTUAL not null);
> create table t13 (a int, b bool not null generated always as ((true )) VIRTUAL);
Ok, done in v10.
> These 3 functions will call StoreRelNotNull to store the not-null constraint.
> StoreConstraints
> AddRelationNotNullConstraints
> AddRelationNewConstraints
> related tests:
> create table t12(b int, a int generated always as (11) virtual,
> constraint nn not null a);
> create table t12(b int, constraint nn not null a, a int generated
> always as (11) virtual);
>
> drop table if exists t14;
> create table t14(b int, a int generated always as (11) virtual);
> alter table t14 add constraint nn not null a;
> alter table t14 add constraint nn not null a no inherit;
Ok, I have added the missing checks and added these test cases to v10.
I didn't put the checks in StoreRelNotNull(), I think that is too late
in the process. (It's already trying to store it. The checking should
come earlier.) I put the checks into AddRelationNewConstraints() and
AddRelationNotNullConstraints(), which already have similar checks.