Horton

Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side

Sergei Kornilov <sk@zsrv.org>

View thread View on postgr.es
From: Sergei Kornilov <sk@zsrv.org>
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Amit Langote <amitlangote09@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-03-02T10:27:23Z
Lists: pgsql-hackers 
Hello

I reviewed a recently published patch. Looks good for me.
One small note: the values ​​for the new definitions in progress.h seems not to be aligned vertically. However, pgindent doesn't objects.

regards, Sergei

Commits

  1. Report NULL as total backup size if it's not estimated.

  2. Make pg_basebackup ask the server to estimate the total backup size, by default.

  3. Report progress of streaming base backup.